Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1122 review comments #1128

Merged
merged 27 commits into from
Jul 29, 2024
Merged

Issue #1122 review comments #1128

merged 27 commits into from
Jul 29, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

Forgot to push fixes for review comments, this impelements this

@JoerivanEngelen
Start moving some logic to an abstract base class
a07e8e5
@JoerivanEngelen
Make methods semi-private
4e0b8c6
@JoerivanEngelen
Move more methods to abstract well class
75fcde6
@JoerivanEngelen
Format code a bit to avoid long line format string
58512fc
@JoerivanEngelen
First version of finished LayeredWell
f037f58
@JoerivanEngelen
Refactor code into separate cases and add layered well cases and tests.
a188d48
@JoerivanEngelen
Better naming for method
aec7051
@JoerivanEngelen
Update changelog
cb1ff38
@JoerivanEngelen
Fix example in docstring
52c6c14
@JoerivanEngelen
format
a66f540
@JoerivanEngelen
Move grouping logic to prepare well rates to separate helper function.
b42fcd6
@JoerivanEngelen
If layer not 0, make LayeredWell
846faaa
@JoerivanEngelen
format
46309f1
@JoerivanEngelen
Better variable naming
88158f7
@JoerivanEngelen
isinstance GridAgnosticWell instead of Well
efd930c
@JoerivanEngelen
Add layer to dataframe
e40f91e
@JoerivanEngelen
Parametrize test with LayeredWell case as well.
58286ab
@JoerivanEngelen
Add test to verify the right classes are instantiated.
b5b261c
@JoerivanEngelen
Test if subclass explicitly
30bd4ea
@JoerivanEngelen
Remove code reduncancy where index was retrieved from other df.
88f934c
@JoerivanEngelen
Specify return type
d5ff265
@JoerivanEngelen
Add return types
42c85d7
@JoerivanEngelen
Expand log message with info that imod.mf6.LayeredWell should be used.
77f6a24
@JoerivanEngelen
Add LayeredWell class to package sanity
16b4798
@JoerivanEngelen
Update docstring, scalars not supported in docstring.
5477bef
@JoerivanEngelen JoerivanEngelen marked this pull request as ready for review July 29, 2024 16:26
@JoerivanEngelen JoerivanEngelen merged commit b95291d into imod5_converter_feature_branch Jul 29, 2024
0 of 5 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1122_LayeredWell_from_imod5_data branch July 29, 2024 16:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoerivanEngelen